[glog] Update to 0.5.0 #20351

chausner · 2021-09-26T01:30:40Z

Describe the pull request

What does your PR fix?

Updates glog to 0.5.0
Which triplets are supported/not supported? Have you updated the CI baseline?

As before, Yes
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/glog/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/glog/portfile.cmake

ports/glog/vcpkg.json

JonLiu1993 · 2021-09-26T06:20:34Z

@chausner ,Thanks for your pr,this is error log:
https://dev.azure.com/vcpkg/public/_build/results?buildId=60211&view=artifacts&pathAsName=false&type=publishedArtifacts

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 59a3f35e7e5a3281e59863a4a0123c325899f8f9 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/g-/glog.json b/versions/g-/glog.json
index 05d3ed5..92b20d8 100644
--- a/versions/g-/glog.json
+++ b/versions/g-/glog.json
@@ -1,8 +1,8 @@
 {
   "versions": [
     {
-      "git-tree": "b3d9b30b67cb8f9817809b2ee623ccaf193cd3c0",
-      "version-string": "0.5.0",
+      "git-tree": "c7df2db9e91a30710420d18bdbfaeaa9114ef888",
+      "version": "0.5.0",
       "port-version": 0
     },
     {

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/glog/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/glog/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/glog/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/glog/portfile.cmake

chausner · 2021-09-28T22:29:43Z

This currently breaks several dependent packages. I also think there is a bug in glog 0.5.0 which I reported at google/glog#715 and tried to workaround with glog_fix_os_defines.patch but it appears there are more issues..

JonLiu1993 · 2021-12-10T07:52:52Z

@chausner, any progress?

chausner · 2021-12-10T18:40:58Z

@chausner, any progress?

No, I'll close this PR.

chausner added 2 commits September 26, 2021 03:30

Update glog to 0.5.0

d73d567

Update CI baseline

aa8189a

github-actions bot approved these changes Sep 26, 2021

View reviewed changes

chausner added 2 commits September 26, 2021 03:59

Fix patch

9645fbc

Update git-tree hash

34f7cde

github-actions bot approved these changes Sep 26, 2021

View reviewed changes

JonLiu1993 self-assigned this Sep 26, 2021

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 26, 2021

JonLiu1993 requested changes Sep 26, 2021

View reviewed changes

ports/glog/vcpkg.json Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Sep 26, 2021

This was referenced Sep 26, 2021

[glog] update to 0.5.0 #18916

Closed

[glog] update to 0.5.0 #17731

Closed

JonLiu1993 linked an issue Sep 26, 2021 that may be closed by this pull request

[glog] update to 0.5.0 #17731

Closed

chausner and others added 2 commits September 27, 2021 21:57

Switch from version-string to version

9b873e8

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Update git-tree hash

79ddedd

github-actions bot requested changes Sep 27, 2021

View reviewed changes

github-actions bot approved these changes Sep 27, 2021

View reviewed changes

chausner added 2 commits September 27, 2021 23:37

Add patch working around a bug in glog

95a2a48

Update git-tree hash

50aec74

github-actions bot approved these changes Sep 27, 2021

View reviewed changes

chausner marked this pull request as draft September 27, 2021 21:44

chausner marked this pull request as ready for review September 27, 2021 22:25

JonLiu1993 removed the requires:author-response label Sep 28, 2021

Merge remote-tracking branch 'origin/master' into HEAD

6563255

github-actions bot approved these changes Sep 28, 2021

View reviewed changes

chausner marked this pull request as draft September 28, 2021 22:28

NancyLi1013 added the depends:upstream-changes Waiting on a change to the upstream project label Sep 30, 2021

NancyLi1013 mentioned this pull request Nov 12, 2021

[glog] Update to 0.5.0 #20840

Closed

chausner closed this Dec 10, 2021

JonLiu1993 mentioned this pull request Dec 24, 2021

[glog] update to v0.5 #22135

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[glog] Update to 0.5.0 #20351

[glog] Update to 0.5.0 #20351

chausner commented Sep 26, 2021

github-actions bot left a comment

github-actions bot left a comment

JonLiu1993 commented Sep 26, 2021

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

chausner commented Sep 28, 2021

JonLiu1993 commented Dec 10, 2021

chausner commented Dec 10, 2021

[glog] Update to 0.5.0 #20351

[glog] Update to 0.5.0 #20351

Conversation

chausner commented Sep 26, 2021

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

JonLiu1993 commented Sep 26, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

chausner commented Sep 28, 2021

JonLiu1993 commented Dec 10, 2021

chausner commented Dec 10, 2021